Skip to content

Add waitForRegistrationVisible#1774

Draft
neekolas wants to merge 1 commit into04-01-fix_flaky_stream_retry_testfrom
03-31-upgrade_to_latest_node_sdk
Draft

Add waitForRegistrationVisible#1774
neekolas wants to merge 1 commit into04-01-fix_flaky_stream_retry_testfrom
03-31-upgrade_to_latest_node_sdk

Conversation

@neekolas
Copy link
Copy Markdown
Contributor

@neekolas neekolas commented Mar 31, 2026

Add waitForRegistrationVisible option to browser and node SDK client registration

  • Adds an optional waitForRegistrationVisible field to OtherOptions in both the browser and node SDKs, accepting WasmVisibilityConfirmationOptions / VisibilityConfirmationOptions respectively.
  • When set, Client.register passes the option through to the underlying registerIdentity call, causing registration to block until the identity is visible on the network.
  • In the browser SDK, the option is forwarded through the worker message pipeline via the client.registerIdentity action type.
  • Both WasmVisibilityConfirmationOptions and VisibilityConfirmationOptions are re-exported from their respective SDK index files.
  • Updates @xmtp/node-bindings and @xmtp/wasm-bindings to dev builds that support this feature.

Macroscope summarized 2c2a85b. (Automatic summaries will resume when PR exits draft mode or review begins).

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 31, 2026

⚠️ No Changeset found

Latest commit: dd7f911

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 31, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
xmtp-js-xmtp-chat Ready Ready Preview, Comment Apr 1, 2026 0:35am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
xmtp-chat-api-service Skipped Skipped Apr 1, 2026 0:35am

Request Review

@vercel vercel bot temporarily deployed to Preview – xmtp-chat-api-service March 31, 2026 23:52 Inactive
Copy link
Copy Markdown
Contributor Author

neekolas commented Mar 31, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@neekolas neekolas changed the base branch from 03-31-add_devcontainer to graphite-base/1774 April 1, 2026 00:34
@neekolas neekolas force-pushed the 03-31-upgrade_to_latest_node_sdk branch from 2c2a85b to dd7f911 Compare April 1, 2026 00:34
@vercel vercel bot temporarily deployed to Preview – xmtp-chat-api-service April 1, 2026 00:34 Inactive
@neekolas neekolas changed the base branch from graphite-base/1774 to 04-01-fix_flaky_stream_retry_test April 1, 2026 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant