test: cover publish rollback on send failure#3406
Draft
xmtp-coder-agent wants to merge 5 commits intoxmtp:mainfrom
Draft
test: cover publish rollback on send failure#3406xmtp-coder-agent wants to merge 5 commits intoxmtp:mainfrom
xmtp-coder-agent wants to merge 5 commits intoxmtp:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3406 +/- ##
==========================================
+ Coverage 83.01% 83.03% +0.02%
==========================================
Files 377 377
Lines 51255 51288 +33
==========================================
+ Hits 42547 42586 +39
+ Misses 8708 8702 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
neekolas
reviewed
Apr 4, 2026
| # The Claude action requires the PR author to have write access to the upstream repo. | ||
| # Fork PRs run under the fork author's identity, which makes automated review fail | ||
| # during the action's permission preflight. | ||
| if: ${{ github.event.pull_request.head.repo.full_name == github.repository }} |
Contributor
There was a problem hiding this comment.
This change is good. I don't think we need the changes below
Contributor
Author
There was a problem hiding this comment.
Kept the fork-PR skip and reverted the extra permission/token changes below it. I also re-ran actionlint on .github/workflows/claude-code-review.yml before pushing the update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3397
Summary
Verification
Note
Add test coverage for publish rollback on send failure in
handle_published_intent_send_failureto-publishstate and have their attempt count incremented.syncinto a newhandle_published_intent_send_failurehelper, which either marks the intent as errored (max attempts reached) or resets it toto-publishfor retry.claude-reviewandtest-iosjobs for fork PRs that lack the required permissions.Macroscope summarized 8aca7e1.