add keystone by waruqi · Pull Request #5459 · xmake-io/xmake-repo

waruqi · 2024-10-09T14:50:24Z

Before adding new features and new modules, please go to issues to submit the relevant feature description first.
Write good commit messages and use the same coding conventions as the rest of the project.
Please commit code to dev branch and we will merge into master branch in feature
Ensure your edited codes with four spaces instead of TAB.

增加新特性和新模块之前，请先到issues提交相关特性说明，经过讨论评估确认后，再进行相应的代码提交，避免做无用工作。
编写友好可读的提交信息，并使用与工程代码相同的代码规范，代码请用4个空格字符代替tab缩进。
请提交代码到dev分支，如果通过，我们会在特定时间合并到master分支上。
为了规范化提交日志的格式，commit消息，不要用中文，请用英文描述。

luadebug · 2024-10-09T15:48:53Z

https://github.com/keystone-engine/keystone/blob/master/docs/COMPILE-WINDOWS.md?plain=1#L27
https://github.com/keystone-engine/keystone/blob/master/docs/COMPILE-WINDOWS-CROSS.md?plain=1#L19
Maybe this will come useful.
Especially their workflows. Like https://ci.appveyor.com/project/aquynh/keystone/history
For example rdbo s own implementation of this https://ci.appveyor.com/project/aquynh/keystone/builds/49914144
rdbo s PR keystone-engine/keystone#582
There could be possibility that it works fine for /MD DLL at least. (Should be good to go for both /MD & /MT I believe)
we have issues due of

kstool -b x64 "mov rax, 1; ret"
error: @programdir\core\sandbox\modules\os.lua:337: cannot exec(kstool -b x64 "mov rax, 1; ret"), No such file or directory

in case of dynamic linked libs for windows using msvc.

# for Windows, do not build kstool if buiding DLL
# TODO: fix this

from src code of cmakelists.txt

luadebug · 2024-10-09T19:12:09Z

+    end)
+
+    on_test(function (package)
+        if not package:is_cross() then


if not package:is_cross() and not is_mode("shared") then

We do not build it because of CMakeLists.txt (at least in case of windows?)
origin src:

# for Windows, do not build kstool if buiding DLL # TODO: fix this

luadebug · 2024-10-10T06:35:05Z

Tencent/ncnn#5592 This might fix NDK builds @waruqi ?

luadebug · 2024-10-10T08:17:53Z

https://github.com/xmake-io/xmake-repo/actions/runs/11269621511/job/31338599801?pr=5459#step:5:254
😟
Patching?
https://github.com/luadebug/xmake-repo/blob/keystone/packages/k/keystone/xmake.lua
https://github.com/luadebug/xmake-repo/blob/keystone/packages/k/keystone/patches/0.9.2/android-NDK-r37.patch

luadebug · 2024-10-10T08:34:00Z

            package:data_set("build_libs_only", true)
        elseif package:is_plat("windows") then
            table.insert(configs, "-DKEYSTONE_BUILD_STATIC_RUNTIME=" .. (package:has_runtime("MT", "MTd") and "ON" or "OFF"))
+        elseif package:is_plat("android") then


Github CI ignored it for some reason?

CMake Warning (dev) at /home/runner/work/xmake-repo/xmake-repo/android-ndk-r27/build/cmake/flags.cmake:46 (if): Policy CMP0057 is not set: Support new IN_LIST if() operator. Run "cmake --help-policy CMP0057" for policy details. Use the cmake_policy command to set the policy and suppress this warning. IN_LIST will be interpreted as an operator when the policy is set to NEW. Since the policy is not set the OLD behavior will be used. Call Stack (most recent call first): /home/runner/.xmake/packages/c/cmake/3.30.2/924bf70cd2964eea80fdac45c84f12e4/share/cmake-3.30/Modules/Platform/Android-Clang.cmake:23 (include) /home/runner/.xmake/packages/c/cmake/3.30.2/924bf70cd2964eea80fdac45c84f12e4/share/cmake-3.30/Modules/Platform/Android-Clang-C.cmake:1 (include) /home/runner/.xmake/packages/c/cmake/3.30.2/924bf70cd2964eea80fdac45c84f12e4/share/cmake-3.30/Modules/CMakeCInformation.cmake:48 (include) CMakeLists.txt:5 (project) This warning is for project developers. Use -Wno-dev to suppress it. CMake Error at /home/runner/work/xmake-repo/xmake-repo/android-ndk-r27/build/cmake/flags.cmake:46 (if): if given arguments: "hwaddress" "IN_LIST" "ANDROID_SANITIZE" Unknown arguments specified Call Stack (most recent call first): /home/runner/.xmake/packages/c/cmake/3.30.2/924bf70cd2964eea80fdac45c84f12e4/share/cmake-3.30/Modules/Platform/Android-Clang.cmake:23 (include) /home/runner/.xmake/packages/c/cmake/3.30.2/924bf70cd2964eea80fdac45c84f12e4/share/cmake-3.30/Modules/Platform/Android-Clang-C.cmake:1 (include) /home/runner/.xmake/packages/c/cmake/3.30.2/924bf70cd2964eea80fdac45c84f12e4/share/cmake-3.30/Modules/CMakeCInformation.cmake:48 (include) CMakeLists.txt:5 (project)

https://github.com/search?q=repo%3Axmake-io%2Fxmake-repo%20MAKE_POLICY_DEFAULT_CMP0057&type=code

cmake_policy(SET CMP0057 NEW)

android-NDK-r37.patch

--- CMakeLists.txt.orig 2024-10-10 08:00:00.000000000 +0000 +++ CMakeLists.txt 2024-10-10 08:10:00.000000000 +0000 @@ -19,6 +19,10 @@ cmake_policy(SET CMP0022 NEW) # automatic when 2.8.12 is required endif() +if (POLICY CMP0057) + cmake_policy(SET CMP0057 NEW) +endif() if (POLICY CMP0051)

😟
Patching?
https://github.com/luadebug/xmake-repo/blob/keystone/packages/k/keystone/xmake.lua
https://github.com/luadebug/xmake-repo/blob/keystone/packages/k/keystone/patches/0.9.2/android-NDK-r37.patch

Well it did not work out.
https://github.com/xmake-io/xmake-repo/actions/runs/11276235247/job/31359534078?pr=5459

error: @programdir\core\sandbox\modules\os.lua:273: -- Android: Targeting API '30' with architecture 'arm64', ABI 'arm64-v8a', and processor 'aarch64' -- Android: Selected unified Clang toolchain -- The C compiler identification is Clang 18.0.1 -- The CXX compiler identification is Clang 18.0.1 -- Configuring incomplete, errors occurred! older versions. CMake Warning (dev) at D:/a/xmake-repo/xmake-repo/ndk/android-ndk-r27/build/cmake/flags.cmake:46 (if): Policy CMP0057 is not set: Support new IN_LIST if() operator. Run "cmake --help-policy CMP0057" for policy details. Use the cmake_policy command to set the policy and suppress this warning. IN_LIST will be interpreted as an operator when the policy is set to NEW. Since the policy is not set the OLD behavior will be used. Call Stack (most recent call first): C:/Program Files/CMake/share/cmake-3.30/Modules/Platform/Android-Clang.cmake:23 (include) C:/Program Files/CMake/share/cmake-3.30/Modules/Platform/Android-Clang-C.cmake:1 (include) C:/Program Files/CMake/share/cmake-3.30/Modules/CMakeCInformation.cmake:48 (include) CMakeLists.txt:5 (project) This warning is for project developers. Use -Wno-dev to suppress it. CMake Error at D:/a/xmake-repo/xmake-repo/ndk/android-ndk-r27/build/cmake/flags.cmake:46 (if): if given arguments: "hwaddress" "IN_LIST" "ANDROID_SANITIZE" Unknown arguments specified Call Stack (most recent call first): C:/Program Files/CMake/share/cmake-3.30/Modules/Platform/Android-Clang.cmake:23 (include) C:/Program Files/CMake/share/cmake-3.30/Modules/Platform/Android-Clang-C.cmake:1 (include) C:/Program Files/CMake/share/cmake-3.30/Modules/CMakeCInformation.cmake:48 (include) CMakeLists.txt:5 (project)

We could rely over cmake.flags file like this:
https://android-review.googlesource.com/c/platform/ndk/+/3211647/1/build/cmake/flags.cmake
according to:
android/ndk#2032 (comment)
Please note it there old versions are being used:
https://github.com/search?q=repo%3Akeystone-engine%2Fkeystone%20cmake_minimum_required&type=code
Reference: https://cmake.org/cmake/help/latest/policy/CMP0057.html

The policy CMP0057 was introduced in CMake 3.3. This policy adds support for the IN_LIST operator in if() conditions, which allows you to check if a value exists in a list more easily. Here’s the relevant information: CMake Version: 3.3 Policy: CMP0057 Description: This policy governs the use of the IN_LIST operator in if() statements. When the policy is set to NEW, the IN_LIST operator is enabled, allowing list membership checks. If you're using a version of CMake older than 3.3, the condition if(POLICY CMP0057) will fail because the policy does not exist in those versions. You need to upgrade to CMake 3.3 or later to use this policy.

luadebug · 2024-10-10T16:26:17Z

Seems resolved now. Good job. 💯
https://github.com/xmake-io/xmake-repo/actions/runs/11277685137/job/31364416700?pr=5459

luadebug · 2024-10-10T17:14:36Z

Tests succeed all checks！Ready to merge @waruqi ！ Good job！ 💯 👍🏻

* add keystone * fix mingw and windows * add python deps * fix python deps * fix kstool * support for ndk r27 * improve build libs only * improve ndk build * fix ndk

waruqi mentioned this pull request Oct 9, 2024

add libmem #5430

Merged

add keystone

1231ee2

luadebug reviewed Oct 9, 2024

View reviewed changes

luadebug reviewed Oct 10, 2024

View reviewed changes

waruqi added 6 commits October 10, 2024 22:33

fix mingw and windows

7bda983

add python deps

c0aa110

fix python deps

9cbd44a

fix kstool

5f0247c

support for ndk r27

baefc11

improve build libs only

ef50efc

waruqi added 2 commits October 11, 2024 00:45

improve ndk build

3ae0b48

fix ndk

632f5ba

waruqi merged commit 6ce7aef into dev Oct 10, 2024

waruqi deleted the keystone branch October 10, 2024 22:19

Navigation Menu

Uh oh!

Uh oh!

add keystone - #5459

add keystone#5459
waruqi merged 9 commits into
devfrom
keystone

waruqi commented Oct 9, 2024

Uh oh!

luadebug commented Oct 9, 2024 •

edited

Loading

Uh oh!

luadebug Oct 9, 2024 •

edited

Loading

Uh oh!

luadebug commented Oct 10, 2024

Uh oh!

luadebug commented Oct 10, 2024 •

edited

Loading

Uh oh!

luadebug Oct 10, 2024 •

edited

Loading

Uh oh!

luadebug Oct 10, 2024

Uh oh!

luadebug Oct 10, 2024 •

edited

Loading

Uh oh!

luadebug commented Oct 10, 2024 •

edited

Loading

Uh oh!

luadebug commented Oct 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

waruqi commented Oct 9, 2024

Uh oh!

luadebug commented Oct 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luadebug Oct 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

luadebug commented Oct 10, 2024

Uh oh!

luadebug commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luadebug Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

luadebug Oct 10, 2024

Choose a reason for hiding this comment

Uh oh!

luadebug Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

luadebug commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luadebug commented Oct 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

luadebug commented Oct 9, 2024 •

edited

Loading

luadebug Oct 9, 2024 •

edited

Loading

luadebug commented Oct 10, 2024 •

edited

Loading

luadebug Oct 10, 2024 •

edited

Loading

luadebug Oct 10, 2024 •

edited

Loading

luadebug commented Oct 10, 2024 •

edited

Loading