fix(acp): preserve failed-turn reload and external ids#147
Open
MoozLee wants to merge 1 commit intoxintaofei:mainfrom
Open
fix(acp): preserve failed-turn reload and external ids#147MoozLee wants to merge 1 commit intoxintaofei:mainfrom
MoozLee wants to merge 1 commit intoxintaofei:mainfrom
Conversation
Keep failed user turns recoverable across reload without hiding persisted history, and avoid overwriting an existing conversation external_id when session/load falls back to session/new. Also restore missing Gemini test imports so the current Rust test suite compiles again.
MoozLee
force-pushed
the
pr/failed-turn-reload-and-external-id-upstream
branch
from
a061ddd to
6bd6648
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #146
Summary
external_idwhensession/loadfalls back tosession/newTest plan
pnpm buildcargo clean --manifest-path src-tauri/Cargo.tomlcargo check --manifest-path src-tauri/Cargo.tomlcargo check --manifest-path src-tauri/Cargo.toml --bin codeg-server --no-default-featurescargo test --manifest-path src-tauri/Cargo.toml gemini --no-runsession/loadfallback no longer overwrites existingexternal_id