fix: should not remove array item while iterating it#209
Open
xia0hj wants to merge 1 commit intoxibyte:mainfrom
Open
fix: should not remove array item while iterating it#209xia0hj wants to merge 1 commit intoxibyte:mainfrom
xia0hj wants to merge 1 commit intoxibyte:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
extrude to get a model, press shift and select more than one face, then release shift and select another face, can not withdraw selected faces normally
caused by removing face from marked-obj array while iterating it
Contributor name: xia0hj
Confirm compliance with JSketcher project license.