Skip to content

Robust exit of particle from mesh when determining segments #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pshriwise wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Robust exit of particle from mesh when determining segments #165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/xdg.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,8 @@ XDG::segments(const Position& start,
{
MeshID ipc = mesh_manager()->implicit_complement();

std::vector<MeshID> prev_elements;

Position r = start;
Direction u = end - start;
double distance = u.length();
Expand All @@ -142,7 +144,12 @@ XDG::segments(const Position& start,
MeshID volume = ID_NONE;
if (current_element == ID_NONE) {
// fire a ray against the implicit complement
auto hit = ray_fire(ipc, r, u, INFTY, HitOrientation::EXITING);
auto hit = ray_fire(ipc, r, u, INFTY, HitOrientation::ANY, &prev_elements);
// if the hit distance is zero, we're likely stuck on an element boundary
// fire again and ignore the previous hit
while (hit.first < TINY_BIT) {
hit = ray_fire(ipc, r, u, INFTY, HitOrientation::ANY, &prev_elements);
}
// if there is no entry point or the distance to the surface
// is past the end point, return
if (hit.second == ID_NONE || hit.first > distance) return segments;
Expand All @@ -155,10 +162,11 @@ XDG::segments(const Position& start,

// determine what element is on the other side of this surface
current_element = find_element(r + u * TINY_BIT);
// if no element is found, we may be exiting the mesh
if (current_element == ID_NONE) {
warning("Ray fire hit surface {}, but could not find element on the other side of the surface.", hit.second);
return {};
return segments;
}
prev_elements.clear();
}
auto vol_segments = mesh_manager()->walk_elements(current_element, r, u, distance);
// add to current set of segments
Expand Down
Loading