Add native CUDA kernel for hydraulic erosion (#961)#967
Merged
brendancol merged 3 commits intomasterfrom Mar 4, 2026
Merged
Conversation
Replaces the CPU-fallback path for CuPy and Dask+CuPy arrays with a real GPU kernel. Each particle maps to one CUDA thread; conflicts at shared heightmap cells are resolved with cuda.atomic.add. Refactors erode() to use ArrayTypeFunctionMapping dispatch instead of manual type checks. Also adds test_erosion.py with 15 tests covering numpy, dask+numpy, cupy, and dask+cupy backends.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #961
Summary
_erode_gpu_kernel(@cuda.jit), one CUDA thread per particle, withcuda.atomic.addfor heightmap conflictserode()to useArrayTypeFunctionMappingdispatch instead of manual type checkstest_erosion.py(15 tests across numpy, dask+numpy, cupy, dask+cupy)21_Hydraulic_Erosion.ipynbNotes
cuda.atomic.addordering depends on thread scheduling. GPU tests use correlation checks instead of exact comparison.Test plan
test_erosion.py, all passing