Merged
Conversation
Add ndwi() and mndwi() to the multispectral module for mapping surface water bodies. Both reuse the existing normalized-ratio backend functions, so all four backends (NumPy, Dask, CuPy, Dask+CuPy) work out of the box. Includes DataArray/Dataset accessor methods and tests against reference values.
- Add API reference entries in multispectral.rst - Add two rows to the README feature matrix - Add notebook 17_Water_Indices.ipynb with synthetic data demo
Number 17 is taken by another in-flight branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ndwi(green, nir)andmndwi(green, swir)toxrspatial/multispectral.pyfor mapping surface water_normalized_ratio_*backend functions, so NumPy, Dask, CuPy, and Dask+CuPy work with no new kernel code.xrsaccessor methods (DataArray and Dataset) for both functionsdocs/source/reference/multispectral.rst17_Water_Indices.ipynbTest plan
pytest xrspatial/tests/test_multispectral.py-- 111 pass (12 new)pytest xrspatial/tests/test_accessor.py-- 21 passCloses #948