ULFM-2 support and native collectives cleanup#29
Open
shamouda wants to merge 6 commits intox10-lang:masterfrom
Open
ULFM-2 support and native collectives cleanup#29shamouda wants to merge 6 commits intox10-lang:masterfrom
shamouda wants to merge 6 commits intox10-lang:masterfrom
Conversation
added 6 commits
April 19, 2018 19:14
completion status Removed failed_coll_handler, and added a boolean flag to coll_handler to notify process failure errors that leads to throwing a DeadPlaceException in Team.
first integration with ULFM Also use one call-back function for collective completion notification
call-back function for reporting collective completion
first integration. Also changes to the way native collectives are called. Now all native collectives return void and use one call-back function for reporting the collective completion status.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1- supporting a recent release of ULFM that provides non-blocking collectives.
2- rolling back to the old mechanism of notifying the completion of a native collective call using a local finish, rather than a boolean return value from X10RT functions.
3- rolling back to using one callback function in native collectives instead of two (one for success, and one for failure). A parameter is added to the original callback function, notifyDPE, for notifying place failures.