fix: cache responses without public directive - #1658
Draft
fiam wants to merge 1 commit into
Draft
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
fiam
force-pushed
the
alberto/eng-9971-cache-without-public
branch
2 times, most recently
from
September 3, 2026 22:32
eb06268 to
7463c1a
Compare
fiam
force-pushed
the
alberto/eng-9971-cache-without-public
branch
from
September 3, 2026 22:41
7463c1a to
1ec78f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coderabbitai summary
Summary
RFC 9111 section 5.2.2.9 states that public is unnecessary when a response is already cacheable: https://www.rfc-editor.org/rfc/rfc9111.html#section-5.2.2.9
Linear: https://linear.app/wundergraph/issue/ENG-9971/when-public-is-not-present-we-should-still-not-skip-caching
Testing
Checklist
Open Source AI Manifesto
This project follows the principles of the Open Source AI Manifesto.