Update branding assets and replace legacy logo with new WSO2 SVG#286
Open
Sachindu-Nethmin wants to merge 1 commit intowso2:mainfrom
Open
Update branding assets and replace legacy logo with new WSO2 SVG#286Sachindu-Nethmin wants to merge 1 commit intowso2:mainfrom
Sachindu-Nethmin wants to merge 1 commit intowso2:mainfrom
Conversation
Sachindu-Nethmin
requested review from
KavinduZoysa,
NipunaRanasinghe,
anupama-pathirage and
rosensilva
as code owners
Contributor
WalkthroughWSO2 branding assets are updated across configuration and theme files, including logo paths in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~9 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@en/theme/material/assets/css/partials/_header.css`:
- Around line 123-126: The CSS for the header logo (.md-header__button.md-logo)
currently sets margin-left: 1.0rem and margin-right: 0.5rem which conflicts with
the PR objective of 1.5rem; update the selector (.md-header__button.md-logo) so
both margin-left and margin-right are 1.5rem (or if the PR objective is wrong,
update the PR text to reflect the values you intend to use).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: da3f8975-2d11-4805-8d4a-6ab660b87a91
⛔ Files ignored due to path filters (6)
en/docs/assets/img/WSO2-logo-black.svgis excluded by!**/*.svgen/docs/assets/img/WSO2-logo-orange.svgis excluded by!**/*.svgen/docs/assets/img/WSO2-logo-white.svgis excluded by!**/*.svgen/docs/assets/img/favicon.pngis excluded by!**/*.pngen/docs/assets/img/logo-for-light.svgis excluded by!**/*.svgen/docs/assets/img/logo.svgis excluded by!**/*.svg
📒 Files selected for processing (3)
en/mkdocs.ymlen/theme/material/assets/css/partials/_header.cssen/theme/material/partials/footer.html
Comment on lines
+123
to
+126
| .md-header__button.md-logo { | ||
| margin-left: 1.0rem; | ||
| margin-right: 0.5rem; | ||
| } |
Contributor
There was a problem hiding this comment.
Header logo margins don’t match the stated PR objective.
PR notes say left/right logo margins should be 1.5rem, but this sets 1.0rem (left) and 0.5rem (right). Please align implementation or update the objective text to avoid design drift.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@en/theme/material/assets/css/partials/_header.css` around lines 123 - 126,
The CSS for the header logo (.md-header__button.md-logo) currently sets
margin-left: 1.0rem and margin-right: 0.5rem which conflicts with the PR
objective of 1.5rem; update the selector (.md-header__button.md-logo) so both
margin-left and margin-right are 1.5rem (or if the PR objective is wrong, update
the PR text to reflect the values you intend to use).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to modernize the WSO2 Integrator BI documentation branding by replacing legacy logo assets with new, cropped SVG variants. This update also includes refining the site header layout to ensure the new icons are correctly sized and positioned.
Goals
logo.svg,logo-for-light.svg, andfavicon.pngwith high-quality SVG icons.mkdocs.ymlto correctly map black and white icon variants to light and dark themes.Approach
WSO2-logo-black.svg,WSO2-logo-orange.svg,WSO2-logo-white.svg) were cropped to their bounding boxes (viewBox="131.09 131.22 262.94 262.94") to remove excess whitespace.mkdocs.ymlto pointlogoto the black variant andlogo_lightto the white variant.WSO2-logo-orange.svgas the site favicon.footer.htmlto update the icon for the "Need support?" section._header.cssto set the logo height to1.6rem.1.5remmargin to both the left and right sides of the logo for balanced positioning.User stories
N/A
Release note
Updated WSO2 Integrator BI documentation branding with new SVG logos and refined header layout.
Documentation
N/A - This is a branding/UI update.
Training
N/A
Certification
N/A
Marketing
N/A
Automation tests
N/A
Manual verification performed on local development server (
mkdocs serve).Security checks
Samples
N/A
Related PRs
N/A
Migrations (if applicable)
N/A
Test environment
Learning
Researched Material for MkDocs header layout and logo customization to ensure proper alignment of square SVG icons.
Summary by CodeRabbit