fix(core): request/response events' stream discrimination.#525
Merged
Conversation
sunrabbit123
approved these changes
Jan 28, 2026
@agentica/benchmark
@agentica/chat
agentica
@agentica/core
create-agentica
@agentica/rpc
@agentica/vector-selector
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how request and response events are typed and constructed in the Agentica core package, improving type safety and clarity for streaming and non-streaming OpenAI chat completion events. The main changes introduce discriminated union types for events, update factory functions to leverage these types, and simplify event handling logic throughout the codebase.
Event Type System Improvements
AgenticaRequestEventandAgenticaResponseEventfrom interfaces to discriminated union types, with distinct types for streaming and non-streaming events, making event handling more type-safe and explicit. [1] [2]Factory Function Updates
createRequestEventandcreateResponseEventto use generic parameters that enforce the correct body and completion types depending on thestreamflag, aligning with the new event type definitions. [1] [2] [3]Request/Response Handling Logic
getChatCompletionFunctionto explicitly set thestreamproperty and use the correct body type for each event.responseproperty with top-levelstream,body, andcompletionproperties. [1] [2]Test Code Adaptation
event.streamandevent.completion), ensuring compatibility with the refactored event types.