fix(schema): accept positive integers and false as valid default_limit

[luhagel]

This should fix #602

Small Issue though:
Setting default_limit: false requires an explicit limit to be passed via the %Flop{} struct, otherwise queries just break on first/limit/page_size can't be blank.
The current behaviour of -1 though defaults to returning all results, just like using Repo.all, which is our current usecase.

So my proposal would be to update the typing to {:or, [:pos_integer, {:in, [false, -1]}]} and updating the docs to refelct that.

Thoughts? @woylie

[woylie]

I think the limit is only required for pagination. If I'm not mistaken, setting pagination: false in the options passed to run/all/validate_and_run/validate should prevent a validation error for a missing limit.

[woylie]

@luhagel I pushed a commit that prevents a limit from being required if pagination is disabled. Does this solve your use case without allowing -1?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.44%. Comparing base (c451fac) to head (bb96018).
⚠️ Report is 22 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #603   +/-   ##
=======================================
  Coverage   84.44%   84.44%           
=======================================
  Files          15       15           
  Lines        1022     1022           
=======================================
  Hits          863      863           
  Misses        159      159           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[luhagel]

@woylie Yes! That works like a charm!

(and sorry for the late reply, got swamped with github notifications)