node: Add comments for hash input to file signer's Sign() method#4622
Open
johnsaigle wants to merge 1 commit intowormhole-foundation:mainfrom
Open
node: Add comments for hash input to file signer's Sign() method#4622johnsaigle wants to merge 1 commit intowormhole-foundation:mainfrom
johnsaigle wants to merge 1 commit intowormhole-foundation:mainfrom
Conversation
johnsaigle
requested review from
SEJeff,
evan-gray and
panoel
as code owners
johnsaigle
force-pushed
the
file-signer-hash-input
branch
2 times, most recently
from
b4281ff to
80b219f
Compare
djb15
approved these changes
Jan 5, 2026
johnsaigle
added
the
quality
johnsaigle
force-pushed
the
file-signer-hash-input
branch
from
80b219f to
23e4b7a
Compare
johnsaigle
force-pushed
the
file-signer-hash-input
branch
from
23e4b7a to
23d63a8
Compare
pleasew8t
approved these changes
Feb 24, 2026
johnsaigle
force-pushed
the
file-signer-hash-input
branch
from
23d63a8 to
604b35b
Compare
johnsaigle
force-pushed
the
file-signer-hash-input
branch
from
604b35b to
855e90a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.