Merged
Conversation
Allowing more complete testing of the token with only the verification being mocked. The separate payload enables creating more tests with differing payloads.
If the users organisation has a stripe link the token includes any entitlements, this should be exposed to client code. Fixes workos#336
dandorman
approved these changes
Jan 27, 2025
Contributor
dandorman
left a comment
dandorman
left a comment
There was a problem hiding this comment.
Looks good to me! A nice bit of test cleanup, too. Thanks!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If the users organisation has a stripe link the token includes any entitlements, this should be exposed to client code.
Fixes #336
First commit includes some minor refactoring to make adding a test for this easier, included separately to make reviewing easier.
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.