This repository was archived by the owner on Mar 7, 2025. It is now read-only.
[Guteneberg] Replace 'steps' with test case number#113
Open
Conversation
hypest
reviewed
Mar 28, 2022
|
|
||
| - [ ] Media Text block - Insert video from device (TC002) - [steps](https://github.com/wordpress-mobile/test-cases/blob/master/test-cases/gutenberg/media-text.md#tc002-v) | ||
| - [ ] Media Text block - Insert image from device (TC002) - [steps](https://github.com/wordpress-mobile/test-cases/blob/master/test-cases/gutenberg/media-text.md#tc002-i) | ||
| - [ ] Media Text block - Insert video from device (TC002) - [TC002-v](https://github.com/wordpress-mobile/test-cases/blob/master/test-cases/gutenberg/media-text.md#tc002-v) |
Contributor
There was a problem hiding this comment.
I wonder if the (TC002) preceding the link is of any use at this stage 🤔 . WDYT about removing it?
Contributor
There was a problem hiding this comment.
(btw, same for the line right below this one)
Member
Author
There was a problem hiding this comment.
hmm yeah, I guess the sub task notation is enough i.e. TC002-v
hypest
approved these changes
Mar 28, 2022
Contributor
hypest
left a comment
hypest
left a comment
There was a problem hiding this comment.
LGTM Jason!
I've only left a minor comment about removing an extra mention of a test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes Github links to the wrong heading when clicking on a test case. Showing the test case in the markdown link makes it easier to verify the link went to the right test. Seeing the test cases in each group also allows for running through a sequence of tests without having to refer back to the test list after each test.