Draft
Conversation
Move locale consistency checks into a separate parallel CI job and disable checkDependencies for app-level lint. This removes ~4-6 min of gem install + fastlane overhead from each lint job's critical path. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Collaborator
Generated by 🚫 Danger |
The baseline was generated with checkDependencies=true, so switching it off causes 234 baseline entries to become "fixed" and surfaces new UnusedResources errors. Reverting until the baseline can be regenerated. Co-Authored-By: Claude Opus 4.6 <[email protected]>
- Set checkDependencies=false for app-level lint to avoid scanning the entire dependency tree - Add add_ignore_attr to local library string configs so merged strings are not flagged as unused without dependency checking - Add separate CI lint jobs for editor, login, and image-editor libraries to maintain lint coverage Co-Authored-By: Claude Opus 4.6 <[email protected]>
Contributor
|
|
Contributor
|
|
The baseline was generated with checkDependencies=true, which meant dependency-sourced issues were included. With checkDependencies=false, the baseline needs to reflect app-module-only lint results. This also captures MissingNullAnnotation warnings that were always present but never baselined. Co-Authored-By: Claude Opus 4.6 <[email protected]>
With checkDependencies=false, lint can't see that certain resources defined in the app are used by editor/login library modules. Add targeted ignore rules in lint.xml for these specific resources instead of regenerating the entire baseline. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Debug variants skip R8/ProGuard minification during compilation, which reduces lint wall time especially on cold caches. All app code is identical between debug and release — BuildConfig.DEBUG checks are runtime conditionals, not compile-time code removal. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lint.shinto a separate parallel CI job, removing ~3-4 min of gem install + fastlane overhead from each lint jobcheckDependenciesfor app-level lint, which avoids analyzing the entire transitive dependency treeTrade-off:
checkDependencies falsemeans lint won't detect string resources used only by library modules. If newUnusedResourceswarnings appear, they can be suppressed via the baseline.Testing instructions
Monitor CI build:
🤖 Generated with Claude Code