-
Notifications
You must be signed in to change notification settings - Fork 3
Implement GutenbergKitResources binary dependency build #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mokagio
wants to merge
48
commits into
trunk
Choose a base branch
from
ainfra-1967-implement-gutenbergkitresources-binary-dependency-build
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,011
−1,868
Open
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
5a492ec
Add GutenbergKitResources target
mokagio ab24052
Migrate `package` to `internal` access
mokagio e74fe01
Use GutenbergKitResources for asset access
mokagio a15a2e0
Remove Gutenberg resources from GutenbergKit target
mokagio 643b926
Add build_xcframework.sh and Makefile targets
mokagio fb64969
Update CI pipeline for local resource builds
mokagio 1b5cd8b
Add Fastlane release automation
mokagio e029a56
Remove tracked built JS assets from Git
mokagio 752e7cb
Use stronger shebang
mokagio f1c70d1
Fix CI: expose resources product, skip signing
mokagio 7a372da
Use -destination instead of -sdk in xcodebuild
mokagio 35e3226
Use GutenbergKitTests scheme for test action
mokagio 9ab740c
Fix XCFramework build for Xcode 26
mokagio 5daee0b
Simplify CI pipeline config
mokagio c1dfec6
Read GITHUB_TOKEN only from env
mokagio 3a58d5b
Avoid shell interpolation in Fastfile sh call
mokagio 34ca96c
Remove section header comments from Fastfile
mokagio cc4c97d
Use XCODEBUILD_CMD macro in test-swift-package
mokagio 9ea6f3c
Use GutenbergKitTests scheme for test target
mokagio 1094255
Fix test scheme: use GutenbergKit-Package
mokagio cacac47
Use OS=latest for simulator destination
mokagio 8ad1fff
Preserve `.gitkeep` during JS build copy
mokagio 071f7ec
Increase `URLCache` clear delay to fix flaky test
mokagio 7527ac7
Remove useless comment
mokagio e80ecda
Use XCODEBUILD_CMD macro in test-swift-package
mokagio 8e35e17
Align Fastlane on v-prefixed tags
mokagio 5b808b8
Add tag-triggered S3 publish step to CI
mokagio 14caa8c
Escape `$` in pipeline interpolation
mokagio 6f87f2a
Use `:xcode:` emoji for XCFramework
mokagio f701d16
Add `install_gems` to S3 publish step
mokagio b4ac14f
Track Gemfile.lock (?!)
mokagio 22ac925
Install gems at the start
mokagio 723b402
Add Bundler settings and rebundle
mokagio d320c39
Use full commit sha in XCFramework ZIP
mokagio 692e5f5
Rename resources dir to fix codesign
mokagio 294a2b8
Track `GutenbergKit/Gutenberg/assets` deletion from automation
mokagio 8a138bf
Fix S3 key to match Package.swift URL
mokagio 2877589
Guard version lanes against empty strings
mokagio cb02250
Extract `required_version!` helper
mokagio 71d39d1
Move S3 publish to a dedicated script
mokagio 77c501f
Update xcframework coordinates
mokagio b3d42b0
Add CFBundleExecutable to framework plist
mokagio 9cc863e
Update xcframework coord to version with Info.plist fix
mokagio 74af0b9
Link XCFramework .o into a dylib
mokagio a524726
Update xcframework revision in `Package.swift`
mokagio 40958e1
Copy dist into GutenbergKitResources for E2E
mokagio 9f49c80
Stop copying dist into GutenbergKit/Gutenberg
mokagio 91a1b47
Extract copy-dist-ios and copy-dist-android
mokagio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| version="${BUILDKITE_TAG#v}" | ||
|
|
||
| if [[ -z "$version" ]]; then | ||
| echo "Error: BUILDKITE_TAG is unset or empty" | ||
| exit 1 | ||
| fi | ||
|
|
||
| install_gems | ||
| make build-resources-xcframework REFRESH_L10N=1 REFRESH_JS_BUILD=1 | ||
| bundle exec fastlane publish_to_s3 "version:${version}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| --- | ||
| BUNDLE_PATH: "vendor/bundle" | ||
| BUNDLE_SPECIFIC_PLATFORM: "false" | ||
| BUNDLE_FORCE_RUBY_PLATFORM: "true" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| source 'https://rubygems.org' | ||
|
|
||
| gem 'fastlane', '~> 2.230' | ||
| gem 'fastlane-plugin-wpmreleasetoolkit', '~> 13.8' |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should not actually be generated anymore. We can keep them here for a while to avoid issues while local copies update, or get rid of them already to avoid carrying dead weight. What do you think?