fix: Toggle the code editor in the iOS Demo app #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore the Swift Observation framework pattern that was likely unintentionally removed in PR #250, allowing the code editor toggle to properly trigger `updateUIViewController` when the state changes.
dcalhoun
requested review from
jkmassel and
kean
and removed request for
jkmassel
Member
Author
|
@kean not urgent, but sending a friendly reminder to review this when you have a moment. Thank you! 🙇🏻♂️ |
kean
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix toggling the code editor in the iOS demo app.
Why?
Fix CMM-1110. The code editor was inaccessible.
How?
Restore the Swift Observation framework pattern that was likely unintentionally removed in PR #250, allowing the code editor toggle to properly trigger
updateUIViewControllerwhen the state changes.Testing Instructions
Accessibility Testing Instructions
N/A, no navigation changes.
Screenshots or screencast
N/A, no visual changes.