Fix Categories were being stripped from products during manual sync.#451
Draft
iamdharmesh wants to merge 6 commits intotrunkfrom
Draft
Fix Categories were being stripped from products during manual sync.#451iamdharmesh wants to merge 6 commits intotrunkfrom
iamdharmesh wants to merge 6 commits intotrunkfrom
Conversation
🔍 WordPress Plugin Check Report
📊 Report
❌ Errors (8)📁 includes/Admin/Product_Editor_Compatibility.php (1 error)
📁 includes/WC_Payments_Compatibility.php (1 error)
📁 includes/Framework/PaymentGateway/Admin/views/html-user-profile-field-customer-id.php (1 error)
📁 includes/Framework/PaymentGateway/Admin/views/html-order-partial-capture.php (1 error)
📁 includes/Framework/PaymentGateway/Admin/views/html-admin-gateway-status.php (1 error)
📁 includes/Framework/PaymentGateway/Admin/views/html-user-payment-token-editor.php (1 error)
📁 includes/Framework/PaymentGateway/Admin/views/html-user-payment-token-editor-token.php (1 error)
📁 includes/Framework/PaymentGateway/Admin/views/html-user-profile-section.php (1 error)
🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check |
1f089b3 to
a658062
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
In PR #408, we added support for syncing multiple categories. However, we missed adding this support to manual synchronization. This PR fixes an issue in manual and interval synchronization where categories were being stripped from products synced from Square.
Note
While working on this, I noticed that synced categories do not maintain the parent–child relationship during synchronization. I have reported a separate issue to explore implementation options and potentially address it.
Closes https://linear.app/a8c/issue/SQUARE-231/categories-get-stripped-off-from-products-that-are-synced-from-square
Steps to test the changes in this Pull Request:
Square SOR:
WooCommerce SOR:
Changelog entry