Skip to content

Comments

Improved sync settings language for better clarity#422

Merged
vikrampm1 merged 2 commits intotrunkfrom
fix/267
Jan 14, 2026
Merged

Improved sync settings language for better clarity#422
vikrampm1 merged 2 commits intotrunkfrom
fix/267

Conversation

@m-muhsin
Copy link
Collaborator

@m-muhsin m-muhsin commented Nov 12, 2025

All Submissions:

  • Does your code follow the WooCommerce Sniffs variant of WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Will this change require new documentation or changes to existing documentation?

Before After
Screenshot 2025-11-12 at 5 56 40 PM Screenshot 2025-11-12 at 5 56 27 PM

Changes proposed in this Pull Request:

This fix changes the language in a description for the Square settings page for better understanding.

Closes #267.

Steps to test the changes in this Pull Request:

  1. Check out to this branch: fix/267
  2. npm run build
  3. Head to /wp-admin/admin.php?page=wc-settings&tab=square
  4. Notice/verify the change in language.

Changelog entry

Fix - Improve sync settings language for better clarity.

Copy link
Collaborator

@dkotter dkotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks good to me but as mentioned in Slack, seems there's one other place this same phrase is used and while it doesn't appear we actually render that anywhere, probably best to update that as well so these two match

@m-muhsin m-muhsin requested a review from dkotter November 13, 2025 01:25
@m-muhsin
Copy link
Collaborator Author

Hi @dkotter I haven now updated the text in the second place as well. Thank you!

@qasumitbagthariya
Copy link
Collaborator

Regression / Smoke Test Report ✅

Tested with Archive File created via "php woorelease.phar build repo_URL" (Composer version 2.8.4, npm version 10.8.2, node version 20.18.1)

Status- Working expected with Plugin Archive/Zip file same as fix specific branch.

Testing Environment

Details
  • WordPress: 6.9
  • Theme: Storefront 4.6.2
  • Theme: Twenty Twenty-Five 1.4
  • WooCommerce - 10.4.3
  • PHP: 8.0.30
  • Web Server: Nginx 1.20.2
  • Browser: Chrome
  • OS: macOS 15.2
  • Branch: smoke-testing

Next Step- Ready to Merge 🚀

@vikrampm1 vikrampm1 modified the milestones: Future Release, 5.2.0 Jan 14, 2026
@vikrampm1 vikrampm1 marked this pull request as ready for review January 14, 2026 20:44
@vikrampm1 vikrampm1 merged commit 29c32fe into trunk Jan 14, 2026
10 of 11 checks passed
@vikrampm1 vikrampm1 deleted the fix/267 branch January 14, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve sync language for clarity

4 participants