Conversation
dkotter
requested changes
Nov 12, 2025
Collaborator
dkotter
left a comment
There was a problem hiding this comment.
Code change looks good to me but as mentioned in Slack, seems there's one other place this same phrase is used and while it doesn't appear we actually render that anywhere, probably best to update that as well so these two match
Collaborator
Author
|
Hi @dkotter I haven now updated the text in the second place as well. Thank you! |
dkotter
approved these changes
Nov 13, 2025
Collaborator
Regression / Smoke Test Report ✅Tested with Archive File created via "php woorelease.phar build repo_URL" (Composer version 2.8.4, npm version 10.8.2, node version 20.18.1) Status- Working expected with Plugin Archive/Zip file same as fix specific branch. Testing Environment Details
Next Step- Ready to Merge 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This fix changes the language in a description for the Square settings page for better understanding.
Closes #267.
Steps to test the changes in this Pull Request:
fix/267npm run build/wp-admin/admin.php?page=wc-settings&tab=squareChangelog entry