Test: verify infinite loop fix for adjacent products #2205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinhtungdu
force-pushed
the
test/verify-infinite-adjacent-loop-fix
branch
2 times, most recently
from
2fdeb3c to
6aa5cf1
Compare
dinhtungdu
force-pushed
the
test/verify-infinite-adjacent-loop-fix
branch
from
6aa5cf1 to
077c597
Compare
kmanijak
approved these changes
Dec 11, 2025
Contributor
kmanijak
left a comment
kmanijak
left a comment
There was a problem hiding this comment.
Super cool to see this test setup added and actual tests for the Storefront_WooCommerce_Adjacent_Products class!
I was able to run tests locally (and they pass!). I only left some nitpick comment and updated the testing steps with composer install (it wasn't there and couldn't run tests at first). But pre-approving.
Great job Tung! 🚀
| "": { | ||
| "name": "storefront", | ||
| "version": "4.6.0", | ||
| "version": "4.6.2", |
Contributor
There was a problem hiding this comment.
Huh, that's weird, it's 4.6.2 on trunk and this branch seems up to date with trunk... 😅 not sure why GitHub shows it as diff.
| public function test_next_product_skips_hidden_with_same_date() { | ||
| $date = '2024-01-01 10:00:00'; | ||
| $current_post = $this->create_product( $date ); | ||
| $hidden_post = $this->create_product( $date, true ); |
Contributor
There was a problem hiding this comment.
Nitpick: let's call it hidden_next similar to the next test where it's called hidden_prev
Suggested change
| $hidden_post = $this->create_product( $date, true ); | |
| $hidden_next = $this->create_product( $date, true ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots
n/a
How to test the changes in this Pull Request:
Check GH Actions or run the test locally.