Skip to content

Conversation

@tyxla
Copy link
Member

@tyxla tyxla commented Dec 11, 2025

Related to WOOPLUG-2450 and woocommerce/woocommerce#50194.

This PR ensures that the theme respects the Coming Soon setting for store-only pages, and doesn't render the mini cart for logged-out users.

This PR is essentially a companion to woocommerce/woocommerce#62388

Screenshots

Before:

Screenshot 2025-12-11 at 10 35 16

After:

Screenshot 2025-12-11 at 10 35 27

How to test the changes in this Pull Request:

If you wish, you can test in conjunction with woocommerce/woocommerce#62388

  • Start with a clean Woo with some products and using the Storefront theme.
  • Go to WC Settings > Site Visibility
  • Turn on the Coming Soon mode with restriction to store only
  • Go to the frontend as a logged-in user.
  • Verify you can see the mini cart.
  • Go to the frontend as a logged-out user.
  • Verify you don't see the mini cart.
  • Verify the block still works well in the admin.

Changelog

Fix – Add compatibility with WooCommerce Coming Soon. #2204

@tyxla tyxla self-assigned this Dec 11, 2025
@tyxla tyxla added the type: enhancement The issue is a request for an enhancement. label Dec 11, 2025
@Aljullu Aljullu requested review from a team and dinhtungdu and removed request for a team December 11, 2025 09:26
@tyxla
Copy link
Member Author

tyxla commented Dec 11, 2025

Thanks for proactively requesting review @Aljullu!

@luisherranz this is very related to woocommerce/woocommerce#62388 which you already approved, I wonder if you had capacity to review this one as well.

@tyxla tyxla requested a review from luisherranz December 11, 2025 09:34
Copy link
Member

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good to me and is testing well!

Image

@tyxla
Copy link
Member Author

tyxla commented Dec 12, 2025

Thanks @dinhtungdu 🙌

@tyxla tyxla merged commit d0279fe into trunk Dec 12, 2025
6 of 7 checks passed
@tyxla tyxla deleted the add/coming-soon-compat branch December 12, 2025 18:51
@tyxla
Copy link
Member Author

tyxla commented Dec 12, 2025

Out of curiosity, how's the releasing of the theme usually handled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement The issue is a request for an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants