[DRAFT] Replace mini-cart widget with mini-cart block and add support for template parts.#2100
Draft
[DRAFT] Replace mini-cart widget with mini-cart block and add support for template parts.#2100
Conversation
Contributor
Author
|
Despite authoring this PR and not having any technical concerns about the implementation (other than followups around cleaning up the CSS), I’m not sure we should actually ship Storefront with these changes. While it would be a good example for classic themes, there are a number of considerations we’d have to make around whether this is opt-in/opt-out, do we default new stores using Storefront to use the Mini-Cart block, what happens with child themes etc. The actual code I did is trivial, the product questions and work around answering those, supporting it after release etc, makes the effort questionable. However, I’m surfacing this so others can give their take if they disagree. |
This was referenced Jan 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this PR should not be merged as is
This is a very limited proof of concept to aid discussions about having Storefront default to using the Mini-Cart block instead of the Woo Core mini-cart widget.
The team has been working on some improvements around the use of
get_refreshed_fragmentsAPI in Woo Core, however the mini cart widget will still enqueue this script (and the resulting ajax calls). Implementing some variation of what is suggested in this PR will accomplish a number of things:Screenshots
The Mini-Cart block in action on the frontend:

The template part:

How to test the changes in this Pull Request:
Additional Notes:
theme.jsonsupport to the theme or enqueue relevant styles in the editor context to achieve the parity.Changelog