Add &display=swap to googlefont URLs#2097
Open
ciderpunx wants to merge 1 commit intowoocommerce:trunkfrom
Open
Add &display=swap to googlefont URLs#2097ciderpunx wants to merge 1 commit intowoocommerce:trunkfrom
ciderpunx wants to merge 1 commit intowoocommerce:trunkfrom
Conversation
Google fonts will add font-display: swap if you pass a parameter to it. This fixes FOIT in many modern browsers which probably makes the user experience a little better. This PR just adds the display=swap parameter to the two places where the google font URL is used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Google fonts will add font-display: swap if you pass a parameter to it. This fixes FOIT in many modern browsers which probably makes the user experience a little better.
This PR just adds the display=swap parameter to the two places where the google font URL is used.
As I understand it this shouldn't be a problem for older browsers, and will be better on newer ones.
How to test the changes in this Pull Request:
You could review the score given on google's pagespeed tool. Before patch you will get a fail on " All text remains visible during webfont loads ", after the patch you won't.
Changelog