fwTPM: Dictionary Attack (DA) hardening and DA/noDA test coverage

[aidangarske]

Description

• fTPM DA hardened to TCG spec with noDA on objects, persistent failedTries, self-heal, lockoutAuth lock, Clear/platform handling, FWTPM_DA_USED_RETRY.
• Found/fixed real bugs mid-review: brick-on-reboot, lockout-counter wipe via clock, lockoutAuth brute-force via Clear.
• New client wrappers added - wolfTPM2_DictionaryAttack{LockReset,Parameters}.
• ~22 unit tests + e2e example + isolated RETRY harness + CI job.
• PR fwTPM: Dictionary Attack (DA) hardening and DA/noDA test coverage #541 opened and server-side + test counterpart to Add Transparent TPM_RC_RETRY auto-resubmit #537

ZD 22030

[dgarske]

Skoll Multi-Scan Review

Modes: review-securityOverall recommendation: APPROVE
Findings: 2 total — 2 posted, 0 skipped
2 finding(s) posted as inline comments (see file-level comments below)

One or more scans did not complete — the results below are partial.

Posted findings

• [Low] [review-security] lockoutAuth recovery timer restarts on every Startup, so clocked builds measure per-boot uptime rather than elapsed wall-clock — src/fwtpm/fwtpm_command.c:695-704
• [Info] [review-security] Failed-auth path persists FLAGS to NV on every failure (flash wear / NV-bound auth latency) — src/fwtpm/fwtpm_command.c:15903-15916

Review generated by Skoll