fix-solid-color-sync#5706
Open
Garold86 wants to merge 1 commit into
Open
Conversation
Fix: sync color to all selected segments, not just main (Solid effect)
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe UDP notification receive path now treats color updates like effect and palette updates in the simple sync branch, and applies incoming color bytes to all selected active segments. ChangesUDP sync color application
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In the UDP notifier receive path (parseNotifyPacket, wled00/udp.cpp), incoming colors were applied only to the main segment, while effect/speed/intensity/palette were applied to all selected segments. So color changes never reached non-main selected segments on receiving instances. Most visible with the Solid effect, where colors[0] is the entire output.
Why / how
Adds color application to the existing per-selected-segment sync loop, mirroring how palette is already handled and reusing the same version-gating as the main-segment color block.
Notes
The original main-segment color block is kept (covers an unselected main segment + CCT). Segment::setColor() early-returns when the value is unchanged, so no double transition.
Only runs when "Segment options" sync is off; the receiveSegmentOptions path already handles per-segment color.
No platformio.ini changes. Built and tested on hardware (ESP32-Ethernet) — Solid color now syncs across all selected segments on all instances.
Fixes #5705
Summary by CodeRabbit