fix: removed unused react-native-safe-area-context from Dependency #2755
+0
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is this a dependency (even a peer dependency) if it's not used in the source code? or is it? |
Contributor
Author
|
@nopitown Thanks for pointing it out. It was previously listed as a dependency, so I assumed it was required and moved it to peerDependencies. After verifying the usage, I’ve now removed it entirely and updated the MR in the latest commit. |
|
Thanks @lalitguy, hopefully a maintainer can approve this PR. There are many users waiting for this to be fixed 👀 |
lalitguy
changed the title
lalitguy
changed the title
|
@M-i-k-e-l @nitzanyiz could you guys review this? |
M-i-k-e-l
approved these changes
Jan 29, 2026
This was referenced Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removed
react-native-safe-area-contextfromdependenciesto prevent duplicate native module installations.Reason
Having this package as a hard dependency can lead to multiple versions of the same native module being installed, which causes build issues in Expo.
Fix
react-native-safe-area-contextfromdependencies. (It was not used in the codebase)Verification
Tested this change by installing the forked branch in an Expo app.
expo-doctorno longer reports duplicatereact-native-safe-area-contextinstallations and the calendar renders correctly.Related issue
Fixes #2728 #2644