Skip to content

SystemUI configuration on init, for Android#4863

Merged
d4vidi merged 17 commits intomasterfrom
feat/demo-mode
Nov 16, 2025
Merged

SystemUI configuration on init, for Android#4863
d4vidi merged 17 commits intomasterfrom
feat/demo-mode

Conversation

@d4vidi
Copy link
Collaborator

@d4vidi d4vidi commented Oct 29, 2025

Description

  • This pull request addresses the issue described here: #<?>

In this pull request, I have introduced the ability to set up system UI via Detox's config.

TODO

  • (Maybe) Separate keyboard from systemUI → systemBehavior
  • Documentation
  • Test coverage
  • Override vars using null
  • Init cache optimization
  • Revisit setStatusBar API (Backlogged: setStatusBar(), systemUI cfg platform parity #4870)
  • unit tests over systemUI CFG helper

For features/enhancements:

  • I have added/updated the relevant references in the documentation files.

For API changes:

  • I have made the necessary changes in the types index file.

@d4vidi d4vidi force-pushed the feat/demo-mode branch 3 times, most recently from 5e819cd to 3930343 Compare November 9, 2025 18:01
@d4vidi d4vidi marked this pull request as ready for review November 11, 2025 14:59
@d4vidi d4vidi requested a review from noomorph as a code owner November 11, 2025 14:59
@d4vidi d4vidi changed the title Demo mode setup for Android SystemUI configuration on init, for Android Nov 13, 2025
Copy link
Collaborator

@noomorph noomorph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nitpicks, but overall I have a positive impression. 😊 See my previous comments.

@d4vidi
Copy link
Collaborator Author

d4vidi commented Nov 13, 2025

A few nitpicks, but overall I have a positive impression. 😊 See my previous comments.

np. Thanks, it was actually important. I'm on it.

@d4vidi d4vidi enabled auto-merge (squash) November 13, 2025 15:45
@d4vidi d4vidi merged commit bcb3392 into master Nov 16, 2025
7 checks passed
@d4vidi d4vidi deleted the feat/demo-mode branch November 16, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants