SystemUI configuration on init, for Android#4863
Merged
Conversation
5e819cd to
3930343
Compare
2eac550 to
ee0e8d4
Compare
noomorph
reviewed
Nov 13, 2025
noomorph
reviewed
Nov 13, 2025
noomorph
reviewed
Nov 13, 2025
detox/src/devices/allocation/drivers/android/AndroidAllocDriver.js
Outdated
Show resolved
Hide resolved
noomorph
reviewed
Nov 13, 2025
noomorph
requested changes
Nov 13, 2025
Collaborator
noomorph
left a comment
There was a problem hiding this comment.
A few nitpicks, but overall I have a positive impression. 😊 See my previous comments.
Collaborator
Author
np. Thanks, it was actually important. I'm on it. |
31fb9a7 to
30821f8
Compare
30821f8 to
651c6a6
Compare
noomorph
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this pull request, I have introduced the ability to set up system UI via Detox's config.
TODO
null