Skip to content

#214, rt-template with in-place child component#216

Open
yatra9 wants to merge 1 commit intowix-incubator:gh-pagesfrom
yatra9:gh-pages
Open

#214, rt-template with in-place child component#216
yatra9 wants to merge 1 commit intowix-incubator:gh-pagesfrom
yatra9:gh-pages

Conversation

@yatra9
Copy link
Copy Markdown

@yatra9 yatra9 commented Mar 7, 2017

This implements #214

I add tests, and modified README also (but, review required, because I'm not a native English speaker)

@nippur72
Copy link
Copy Markdown
Contributor

nippur72 commented Mar 8, 2017

great, I have two suggestions:

  • can we rename in-place with something more intuitive, e.g. component ? Or perhaps we could have a new attribute <rt-prop>:
<rt-template prop="mybutton" component>
   <button>my</button>
</rt-template>

<!-- or -->

<rt-prop name="mybutton">
   <button>my</button>
</rt-prop>
  • just for code styling, use string interpolation when throwing errors:
throw RTCodeError.build(context, child, `'rt-template' should have a '${templateNode_PropAttr}' attribute`);

instead of the more verbose

throw RTCodeError.build(context, child, "'rt-template' should have a " + templateNode_PropAttr + ' attribute');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants