Skip to content

[next]: content loaders breaking changes#12824

Merged
florian-lefebvre merged 19 commits intov6from
feat/content-loader-create-schema
Dec 4, 2025
Merged

[next]: content loaders breaking changes#12824
florian-lefebvre merged 19 commits intov6from
feat/content-loader-create-schema

Conversation

@florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Dec 3, 2025

Description (required)

Related issues & labels (optional)

  • Closes #
  • Suggested label:

For Astro version: 6.0. See astro PR #14759.

@florian-lefebvre florian-lefebvre added this to the v6.0.0 docs milestone Dec 3, 2025
@florian-lefebvre florian-lefebvre self-assigned this Dec 3, 2025
@netlify
Copy link

netlify bot commented Dec 3, 2025

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 78d7c89
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/69317c13611519000801d4c0
😎 Deploy Preview https://deploy-preview-12824--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Dec 3, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/upgrade-to/v6.mdx Source changed, localizations will be marked as outdated.
en/reference/content-loader-reference.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@florian-lefebvre florian-lefebvre marked this pull request as ready for review December 3, 2025 13:18
Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me! I left some comments around things that could be clarified in the reference.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Florian! Here's a mostly complete review except for the new createSchema reference docs itself yet (since I think there is still conversation between you and Armand re: what the examples should look like and how this might affect other docs etc.) I will wait until it's time to review language there, but this reviews the upgrade guide!

florian-lefebvre and others added 2 commits December 3, 2025 16:59
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
@sarah11918
Copy link
Member

REMINDER that I haven't reviewed the actual createSchema() entry yet! But it looks like all the previous comments are quickly getting resolved, so I'll do that now!

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny polishing thoughts for the API reference!

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

standardize code examples showing load: and schema:

Co-authored-by: Sarah Rainsberger <[email protected]>
Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks ready to me! 🚀

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just fixed a typo, but I think this looks great now! Well done both of you!

@florian-lefebvre florian-lefebvre merged commit 4859404 into v6 Dec 4, 2025
9 of 10 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/content-loader-create-schema branch December 4, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants