[next]: content loaders breaking changes#12824
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Thanks, this looks good to me! I left some comments around things that could be clarified in the reference.
Co-authored-by: Armand Philippot <[email protected]>
sarah11918
left a comment
There was a problem hiding this comment.
Thanks Florian! Here's a mostly complete review except for the new createSchema reference docs itself yet (since I think there is still conversation between you and Armand re: what the examples should look like and how this might affect other docs etc.) I will wait until it's time to review language there, but this reviews the upgrade guide!
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Armand Philippot <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
|
REMINDER that I haven't reviewed the actual |
Co-authored-by: Sarah Rainsberger <[email protected]>
sarah11918
left a comment
There was a problem hiding this comment.
Tiny polishing thoughts for the API reference!
sarah11918
left a comment
There was a problem hiding this comment.
standardize code examples showing load: and schema:
Co-authored-by: Sarah Rainsberger <[email protected]>
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Thanks, this looks ready to me! 🚀
sarah11918
left a comment
There was a problem hiding this comment.
I just fixed a typo, but I think this looks great now! Well done both of you!
Description (required)
Related issues & labels (optional)
For Astro version:
6.0. See astro PR #14759.