[v6] trailing slash never for endpoints with file extension

[florian-lefebvre]

Co-authored-by: Sarah Rainsberger 5098874+sarah11918@users.noreply.github.com

Description (required)

Related issues & labels (optional)

• Closes #
• Suggested label:

For Astro version: 6.0. See astro PR #14457.

[netlify]

✅ Deploy Preview for astro-docs-2 ready!

Name	Link
🔨 Latest commit	277a9b7
🔍 Latest deploy log	https://app.netlify.com/projects/astro-docs-2/deploys/68dd52fef8a3060007628a75
😎 Deploy Preview	https://deploy-preview-12467--astro-docs-2.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[astrobot-houston]

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File	Note
en/guides/endpoints.mdx	Source changed, localizations will be marked as outdated.
en/guides/upgrade-to/v6.mdx	Source changed, localizations will be marked as outdated.

Warnings reference

Icon	Description
🔄️	The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

[sarah11918]

Thanks Florian! Left some comments below to see what you think!

[florian-lefebvre]

@sarah11918 just checked the docs and we call these routes "static file endpoints" if that helps!

[sarah11918]

ugh... pending reviews strike again!

[sarah11918]

we call these routes "static file endpoints" if that helps!

Actually, I'm not entirely sure we do? I was rereading that page and it looks like we have two separate static / SSR route categories, but... the static one defines what these routes are, and the SSR one only describes extra functionality if the route is rendered on demand? (Though one could easily just jump to the later section for on-demand rendered routes, and not realize that we've explained what these are in the "static" section.) So, probably a case of adding SSR on after the fact and not getting the info hierarchy quite right there, tbh 😅

[florian-lefebvre]

That's how I understood this part:

The .js or .ts extension will be removed during the build process, so the name of the file should include the extension of the data you want to create. For example, src/pages/data.json.ts will build a /data.json endpoint.

[sarah11918]

Furthermore, I don't think this page shows any examples of an endpoint that does not contain a file extension before the .js/.ts... so a) maybe we should in general? and b) this extra info won't make sense unless we're VERY explicit about which ones cannot have the trailing slash (since we otherwise make no mention of differentiating these endpoints)

[sarah11918]

The .js or .ts extension will be removed during the build process, so the name of the file should include the extension of the data you want to create. For example, src/pages/data.json.ts will build a /data.json endpoint.

But, I think we mean for this to also be true about the Server Endpoints?

Everything described in the static file endpoints section can also be used in SSR mode... This unlocks new features that are unavailable at build time

And no examples showing anything without an extension?

e.g. we never show how to make something like /api/submit ... is that kind of route only on-demand rendered?

[florian-lefebvre]

NWTWWHB for the win!

we never show how to make something like /api/submit ... is that kind of route only on-demand rendered?

Yeah I don't think there's a case outside of SSR

[sarah11918]

This LGTM, but let's put it in the "breaking changes" category instead of "changed defaults"!

[sarah11918]

Yeah I don't think there's a case outside of SSR

If so, I do think future works should be to explicitly show an example of that in the on-demand rendered section, but out of scope here!