fix: slot attribute stripped inside expression#1132
Open
openscript wants to merge 3 commits intowithastro:mainfrom
Open
fix: slot attribute stripped inside expression#1132openscript wants to merge 3 commits intowithastro:mainfrom
slot attribute stripped inside expression#1132openscript wants to merge 3 commits intowithastro:mainfrom
Conversation
🦋 Changeset detectedLatest commit: c8dc178 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
openscript
changed the title
slot attribute stripped inside expressionslot attribute stripped inside expression
Princesseuh
approved these changes
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1095
Changes
When printing the AST and a
slotattribute is found, we walk up the tree to check whether we are in an Astro component or a web component.Testing
We check now different variations of nesting a web component inside expression blocks, to see if the
slotattribute is removed or not.Docs
bug fix only