Skip to content

refactor(netlify): migrate tests to typescript#16395

Merged
ematipico merged 1 commit intowithastro:mainfrom
ocavue-forks:ocavue-ts-test-netlify
Apr 20, 2026
Merged

refactor(netlify): migrate tests to typescript#16395
ematipico merged 1 commit intowithastro:mainfrom
ocavue-forks:ocavue-ts-test-netlify

Conversation

@ocavue
Copy link
Copy Markdown
Contributor

@ocavue ocavue commented Apr 19, 2026

Part of #16241

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 19, 2026

⚠️ No Changeset found

Latest commit: 6df85d6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Apr 19, 2026
@ocavue ocavue force-pushed the ocavue-ts-test-netlify branch from 1b7e49f to 9732895 Compare April 20, 2026 08:53
@ocavue ocavue force-pushed the ocavue-ts-test-netlify branch from 25fbf38 to 6df85d6 Compare April 20, 2026 10:44
@ocavue ocavue marked this pull request as ready for review April 20, 2026 11:03
return baseLoadFixture(config);
}

export class SpyIntegrationLogger extends AstroIntegrationLogger {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we use the SpyLogger from test-utils in core, and then use forkIntegrationLogger?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No directly. We need to tweak the code from SpyLogger to make it works.

options: AstroLogOptions = {
destination: { write: () => true },
level: 'silent',
};

I can do some refactor about the logger used in tests after I migrate all js files to ts.

Copy link
Copy Markdown
Member

@ematipico ematipico Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine. I will handle it. I am working on the astro logger, and there are some refactors ahead.

@ematipico ematipico merged commit 05e70f7 into withastro:main Apr 20, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: integration Related to any renderer integration (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants