Merged
Conversation
|
b9e2e38 to
9ab3046
Compare
matthewp
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR was vibe coded. I checked the implementation code, but I let the AI porting all tests to be unit.
This PR makes the implementation of i18n more testable.
I18nRouterthat accepts a context, and emits decisions. Eventually, this decision is given to the middleware, which decides what to do.Note
I kept the existing tests for safety. The next PR will remove them (or next commit)
Testing
Green CI
Docs
Not needed