Skip to content

chore: remove unnecessary eslint-disable-s#8004

Open
tonyganchev wants to merge 1 commit intowireapp:mainfrom
tonyganchev:main
Open

chore: remove unnecessary eslint-disable-s#8004
tonyganchev wants to merge 1 commit intowireapp:mainfrom
tonyganchev:main

Conversation

@tonyganchev
Copy link
Copy Markdown

Pull Request

Summary

Two cli.ts files had their header validation disabled because it would fail because of the leading she-bang comment.

The problem was that eslint-plugin-header does not tolerate an empty line between the shebang and the header. So there is no need for the eslint-disable pragmas - we just get rid of the empty line.


Security Checklist (required)

  • External inputs are validated & sanitized on client and/or server where applicable.
  • API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
  • No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
  • Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Accessibility (required)

Standards Acknowledgement (required)


The problem was that _eslint-plugin-header_ does not tolerate an empty
line between the shebang and the header. So there is no need for the
`eslint-disable` pragmas - we just get rid of the empty line.
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant