chore: remove unnecessary eslint-disable-s#8004
Open
tonyganchev wants to merge 1 commit intowireapp:mainfrom
Open
chore: remove unnecessary eslint-disable-s#8004tonyganchev wants to merge 1 commit intowireapp:mainfrom
tonyganchev wants to merge 1 commit intowireapp:mainfrom
Conversation
The problem was that _eslint-plugin-header_ does not tolerate an empty line between the shebang and the header. So there is no need for the `eslint-disable` pragmas - we just get rid of the empty line.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Pull Request
Summary
Two
cli.tsfiles had their header validation disabled because it would fail because of the leading she-bang comment.The problem was that eslint-plugin-header does not tolerate an empty line between the shebang and the header. So there is no need for the
eslint-disablepragmas - we just get rid of the empty line.Security Checklist (required)
Accessibility (required)
Standards Acknowledgement (required)