Fix/console transport memory leak#2564
Open
yash-dayama wants to merge 4 commits intowinstonjs:masterfrom
Open
Conversation
added 2 commits
July 29, 2025 14:42
- Remove unnecessary setImmediate wrapper in Console transport log method - Add stress tests to verify memory usage and event listener cleanup - Fix issue winstonjs#2548
This file should be part of the PR
Revert to master version of file, no reason this should have changed
Contributor
|
@yash-dayama for some reason |
Contributor
|
@yash-dayama I'm also seeing some test failures from the CI system, can you please investigate? Thanks for your time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2548
Fix Memory Leak in Console Transport
Description
This PR fixes a memory leak issue in the Console transport that occurs when logging a large number of messages in quick succession. The issue was reported in #2548 and occurs in Winston 3.x.x versions.
Problem
The Console transport was using
setImmediateto emit the 'logged' event, which under high load (many log messages) would create a large number of pending operations that weren't being cleaned up properly. This led to increased memory usage over time.Solution
The fix removes the unnecessary
setImmediatewrapper when emitting the 'logged' event. Since the console writes are already asynchronous (via stdout/stderr streams), there's no need for the additional async operation. This change significantly reduces memory usage under high load while maintaining the same functionality.Changes
setImmediatewrapper in Console transport's log methodTesting
Added new stress tests that:
To run the tests: