Fixed the return type of method profile of class Logger#2541
Open
Mallikarjun-0 wants to merge 1 commit intowinstonjs:masterfrom
Open
Fixed the return type of method profile of class Logger#2541Mallikarjun-0 wants to merge 1 commit intowinstonjs:masterfrom
Mallikarjun-0 wants to merge 1 commit intowinstonjs:masterfrom
Conversation
… possibility that the method might return a boolean.
Author
|
Hi @DABH, I think this PR got skipped because of its brevity. SummaryThis PR, fixes the return type hint of the method Example:const winston = require('winston');
const logger = winston.createLogger({
level: 'info',
format: winston.format.simple(),
transports: [
new winston.transports.Console()
]
});
var temp = logger.profile('test');
console.log(typeof temp); // prints 'object' as 'Logger' is returned
setTimeout(() => {
temp = logger.profile('test');
console.log(typeof temp); // prints 'boolean`
}, 1000); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a possibility that the method profile of class Logger might return a boolean.