[WFLY-14255] Promote to default stability#780
Conversation
|
yeah... this is bummer. Will push new one than. |
cf78a42 to
8f71bb2
Compare
|
|
||
| == Admin Clients | ||
|
|
||
| CLI should not have problems. HAL might need update. |
There was a problem hiding this comment.
HAL might need update.
Needs to be clarified now, especially if this is going with default stability.
undertow/WFLY-21525_Make_resuseXForwarded_and_rewriteHost_configurable.adoc
Show resolved
Hide resolved
8f71bb2 to
50b593e
Compare
50b593e to
9a577e5
Compare
9a577e5 to
2f17b6d
Compare
2f17b6d to
4d951a8
Compare
4d951a8 to
87102df
Compare
87102df to
fdab80a
Compare
rhusar
left a comment
There was a problem hiding this comment.
Title is also wrong - correct issue is https://issues.redhat.com/browse/WFLY-21525
undertow/WFLY-21525_Make_resuseXForwarded_and_rewriteHost_configurable.adoc
Outdated
Show resolved
Hide resolved
undertow/WFLY-21525_Make_resuseXForwarded_and_rewriteHost_configurable.adoc
Outdated
Show resolved
Hide resolved
undertow/WFLY-21525_Make_resuseXForwarded_and_rewriteHost_configurable.adoc
Outdated
Show resolved
Hide resolved
undertow/WFLY-21525_Make_resuseXForwarded_and_rewriteHost_configurable.adoc
Outdated
Show resolved
Hide resolved
undertow/WFLY-21525_Make_resuseXForwarded_and_rewriteHost_configurable.adoc
Show resolved
Hide resolved
undertow/WFLY-21525_Make_resuseXForwarded_and_rewriteHost_configurable.adoc
Show resolved
Hide resolved
undertow/WFLY-21525_Make_resuseXForwarded_and_rewriteHost_configurable.adoc
Outdated
Show resolved
Hide resolved
| # the original https://github.com/wildfly/wildfly-proposals/issues issue that was used to track the implementation of | ||
| # that feature. | ||
| promotes: https://github.com/wildfly/wildfly-proposals/pull/444 | ||
| promoted-by: https://github.com/wildfly/wildfly-proposals/issues/793 |
There was a problem hiding this comment.
This one doesn't need a value, this is intended to link to the propsal that promotes this to a higher stability level.
|
|
||
| == Community Documentation | ||
|
|
||
| At minimal should have detailed description. Test plan has references to online resources which explain what thost options do. |
There was a problem hiding this comment.
Can you rephrase this? I don't understand what you mean here. (what is 'thost')
| [[test_plan]] | ||
| == Test Plan | ||
|
|
||
| https://gitlab.cee.redhat.com/jbossqe-eap/test-plans/-/merge_requests/821[Test Plan] |
There was a problem hiding this comment.
This is not publicly accessible.
I am not sure how we handle this for default.
There was a problem hiding this comment.
I would just omit the link I think, maybe a short description of the testing that exists?
|
|
||
| == Release Note Content | ||
|
|
||
| Proxy configuration option now support: |
There was a problem hiding this comment.
| Proxy configuration option now support: | |
| Proxy configuration options now support: |
|
|
||
| == Implementation Plan | ||
|
|
||
| Already done. |
There was a problem hiding this comment.
Well, not really. This is meant to cover how this will be delivered and coordinated with e.g. HAL-2050.
undertow/WFLY-21525_Make_resuseXForwarded_and_rewriteHost_configurable.adoc
Show resolved
Hide resolved
| # If this issue tracks the promotion of a previously completed feature to a higher stability level, provide the URL of | ||
| # the original https://github.com/wildfly/wildfly-proposals/issues issue that was used to track the implementation of | ||
| # that feature. | ||
| promotes: https://github.com/wildfly/wildfly-proposals/pull/444 |
There was a problem hiding this comment.
The analysis doc under that PR should have it's promoted-by field updated to point to this new analysis doc.
This is similar to RFCs where they have "Obsoletes" and "Obsoleted" by so the relationship can be navigated.
@darranl Also, it links the wrong issue... |
fdab80a to
15b0265
Compare
Issue: https://issues.redhat.com/browse/WFLY-21525
Related Issue: https://issues.redhat.com/browse/WFLY-14255
Refs: https://issues.redhat.com/browse/EAP7-1837#