Add support to record IPv4 encapsulated packets#35
Open
Shikugawa wants to merge 2 commits intowide-vsix:mainfrom
Open
Add support to record IPv4 encapsulated packets#35Shikugawa wants to merge 2 commits intowide-vsix:mainfrom
Shikugawa wants to merge 2 commits intowide-vsix:mainfrom
Conversation
Author
|
@slankdev Please check it. cc @proelbtn @ninilosso |
proelbtn
reviewed
Jun 23, 2023
| if (inner_ih->ihl < 5) | ||
| return TC_ACT_SHOT; |
Member
There was a problem hiding this comment.
If the IP header has options, inner_ih->ihl will be greater than 5, right? If you add the IP header (20) length in process_ipv4_tcp, you may need to implement it like the following?
Suggested change
| if (inner_ih->ihl < 5) | |
| return TC_ACT_SHOT; | |
| if (inner_ih->ihl != 5) | |
| return TC_ACT_SHOT; |
Member
There was a problem hiding this comment.
or you need to calculate correct offset with ih->ihl.
Author
There was a problem hiding this comment.
Actually this tool supports IP option (ihl > 5) but current this PR doesn't calculate offset of inner IP with correct ihl. So let me fix it.
proelbtn
approved these changes
Jun 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support to collect flow logs for IPv4 encapsulated packets.