Make Document origin alias its policy container's origin.#1142
Open
wanderview wants to merge 1 commit intowhatwg:mainfrom
Open
Make Document origin alias its policy container's origin.#1142wanderview wants to merge 1 commit intowhatwg:mainfrom
wanderview wants to merge 1 commit intowhatwg:mainfrom
Conversation
4 tasks
wanderview
added a commit
to wanderview/html
that referenced
this pull request
Jan 10, 2023
This change also depends on whatwg/dom#1142.
annevk
reviewed
Jan 11, 2023
Member
annevk
left a comment
annevk
left a comment
There was a problem hiding this comment.
"Policy Container" should be "policy container".
dom.bs
Outdated
| <a for=Document>mode</a> to those of <var>node</var>. | ||
| <a for=Document>URL</a>, <a for=Document>policy container</a>'s | ||
| <a for="Policy Container">origin</a>, <a for=Document>type</a>, and <a for=Document>mode</a> | ||
| to those of <var>node</var>. |
Member
There was a problem hiding this comment.
I think now we're using nested data structures this seems less clear. Perhaps it's best to just write them all out explicitly?
set copy's x to node's x, ...
Member
Author
There was a problem hiding this comment.
I tried to break these out, but since this won't build before the other PR lands its difficult for me to see if it looks reasonable or not.
Member
There was a problem hiding this comment.
I was thinking a long inline paragraph, but we can wait until the HTML PR is ready.
wanderview
added a commit
to wanderview/html
that referenced
this pull request
Jan 11, 2023
This change also depends on whatwg/dom#1142.
This change depends on the changes in whatwg/html#8447 which adds origin to policy container.
wanderview
force-pushed
the
dev-policy-container-origin
branch
from
2e38722 to
27ee644
Compare
wanderview
added a commit
to wanderview/html
that referenced
this pull request
Jan 12, 2023
This change also depends on whatwg/dom#1142.
wanderview
added a commit
to wanderview/html
that referenced
this pull request
Jan 12, 2023
This change also depends on whatwg/dom#1142.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change depends on the changes in whatwg/html#8447 which adds origin to policy container.
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff