Add correct units for bmi calculator and weight entries #1038
Open
jiany18 wants to merge 2 commits intowger-project:masterfrom
Open
Add correct units for bmi calculator and weight entries #1038jiany18 wants to merge 2 commits intowger-project:masterfrom
jiany18 wants to merge 2 commits intowger-project:masterfrom
Conversation
Member
|
Thanks for the PR! There are actually a couple of places where we do consider whether the user uses metric or imperial units, but yeah, it would be better to explicitly display the units and change them according to the profile settings. The BMI calculator actually is aware of this and will convert the values accordingly in calculate_bmi() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes