Skip to content

Theme: adding multiple components to theme template#2685

Open
Garneauma wants to merge 2 commits intowet-boew:masterfrom
Garneauma:theme-template
Open

Theme: adding multiple components to theme template#2685
Garneauma wants to merge 2 commits intowet-boew:masterfrom
Garneauma:theme-template

Conversation

@Garneauma
Copy link
Copy Markdown
Collaborator

Changes related to WET-607.

Copy link
Copy Markdown
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review

Comment thread components/gc-most-requested/samples/gc-most-requested-highlight.html Outdated
Comment thread templates/theme/theme-ircc-en.html
Copy link
Copy Markdown
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look amazing, I reviewed all example + all code + quickly explored the implementation feasibility into our MWS.

There is :

  • one small addition to do in our documentation.
  • Extend the gc service information to include the internal highlighted doormat by using what you did directly inside the theme working example.

Cheers

Comment thread components/gc-most-requested/index.json-ld Outdated
Comment thread templates/theme/theme-ircc-en.html
@duboisp duboisp self-assigned this Dec 29, 2025
Comment thread templates/theme/theme-en.html Outdated
@Garneauma Garneauma force-pushed the theme-template branch 2 times, most recently from 3fdd761 to e858453 Compare February 25, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants