WCAG Assessment - Tab interface - Wet 369#2203
Closed
hongbinyu413 wants to merge 2 commits intowet-boew:masterfrom
Closed
WCAG Assessment - Tab interface - Wet 369#2203hongbinyu413 wants to merge 2 commits intowet-boew:masterfrom
hongbinyu413 wants to merge 2 commits intowet-boew:masterfrom
Conversation
duboisp
requested changes
Sep 7, 2023
Member
duboisp
left a comment
duboisp
left a comment
There was a problem hiding this comment.
- The html files to contain the similar issue as the other PR for the toggles.
- Rename the folder "tab inteface" for the plugin technical name
- Create the index.json-ld file, similar to what I did for the share this page plugin.
| "dct:description": "Accessibility conformance reports of Tabbed Interface", | ||
| "earl:pointer": { | ||
| "@type": "oa:CssSelector", | ||
| "@value": "gc-features" |
Member
There was a problem hiding this comment.
The CSS selector need to be replaced by the tab-interface CSS selector
hongbinyu413
force-pushed
the
wet-369
branch
from
19d7d49 to
2a505a6
Compare
hongbinyu413
temporarily deployed
to
github-ci
GitHub Actions
Inactive
AtlakM
suggested changes
Feb 13, 2024
Contributor
AtlakM
left a comment
AtlakM
left a comment
There was a problem hiding this comment.
css selector needs update
duboisp
requested changes
Feb 13, 2024
Member
duboisp
left a comment
duboisp
left a comment
There was a problem hiding this comment.
All those 3 files need to be moved into this folder: /wet-boew/wb-tabs/reports
| "dct:description": "Accessibility conformance reports of Tabbed Interface", | ||
| "earl:pointer": { | ||
| "@type": "oa:CssSelector", | ||
| "@value": "tab-interface" |
Member
There was a problem hiding this comment.
Suggested change
| "@value": "tab-interface" | |
| "@value": ".wb-tabs" |
Comment on lines
+3
to
+13
| "title": "Assessment d'accessibilité #1 - Interface à onglets", | ||
| "language": "fr", | ||
| "description": "Partielle. Évaluation des nouveaux critères de succès aux niveaux A et AA de WCAG 2.1 et WCAG 2.2", | ||
| "tag": "tabs", | ||
| "parentdir": "tabs", | ||
| "parentPage": "Interface à onglets", | ||
| "parentPageURL": "skiplinks", | ||
| "altLangPage": "a11y-1-en.html", | ||
| "dateModified": "2023-07-06", | ||
| "layout": "assessment_wrote_en-fr", | ||
| "reportURL": "a11y-1.json" |
Member
There was a problem hiding this comment.
Suggested change
| "title": "Assessment d'accessibilité #1 - Interface à onglets", | |
| "language": "fr", | |
| "description": "Partielle. Évaluation des nouveaux critères de succès aux niveaux A et AA de WCAG 2.1 et WCAG 2.2", | |
| "tag": "tabs", | |
| "parentdir": "tabs", | |
| "parentPage": "Interface à onglets", | |
| "parentPageURL": "skiplinks", | |
| "altLangPage": "a11y-1-en.html", | |
| "dateModified": "2023-07-06", | |
| "layout": "assessment_wrote_en-fr", | |
| "reportURL": "a11y-1.json" | |
| "title": "Assessment d'accessibilité #1 - Interface à onglets", | |
| "language": "fr", | |
| "description": "Partielle. Évaluation des nouveaux critères de succès aux niveaux A et AA de WCAG 2.1 et WCAG 2.2", | |
| "altLangPage": "ally-1-en.html", | |
| "dateModified": "2023-07-06", | |
| "layout": "assessment_wrote_en-fr", | |
| "reportURL": "ally-1.json" |
Comment on lines
+3
to
+13
| "title": "Accessibility assessment #1 - Tabbed Interface", | ||
| "language": "en", | ||
| "description": "Partial. Evaluation of new Success Criteria at Level A and Level AA of WCAG 2.1 and WCAG 2.2", | ||
| "tag": "tabs", | ||
| "parentdir": "tabs", | ||
| "parentPage": "Tabbed Interface", | ||
| "parentPageURL": "Tabs", | ||
| "altLangPage": "a11y-1-fr.html", | ||
| "dateModified": "2023-07-06", | ||
| "layout": "assessment_wrote_en-en", | ||
| "reportURL": "pre-a11y-1.json" |
Member
There was a problem hiding this comment.
Suggested change
| "title": "Accessibility assessment #1 - Tabbed Interface", | |
| "language": "en", | |
| "description": "Partial. Evaluation of new Success Criteria at Level A and Level AA of WCAG 2.1 and WCAG 2.2", | |
| "tag": "tabs", | |
| "parentdir": "tabs", | |
| "parentPage": "Tabbed Interface", | |
| "parentPageURL": "Tabs", | |
| "altLangPage": "a11y-1-fr.html", | |
| "dateModified": "2023-07-06", | |
| "layout": "assessment_wrote_en-en", | |
| "reportURL": "pre-a11y-1.json" | |
| "title": "Accessibility assessment #1 - Tabbed Interface", | |
| "language": "en", | |
| "description": "Partial. Evaluation of new Success Criteria at Level A and Level AA of WCAG 2.1 and WCAG 2.2", | |
| "altLangPage": "ally-1-fr.html", | |
| "dateModified": "2023-07-06", | |
| "layout": "assessment_wrote_en-en", | |
| "reportURL": "ally-1.json" |
Collaborator
|
Superseded by #2314 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.