This repository was archived by the owner on Oct 27, 2022. It is now read-only.
Open
Conversation
added 3 commits
March 28, 2021 16:12
Byteron
reviewed
Mar 29, 2021
Byteron
reviewed
Mar 30, 2021
Comment on lines
+45
to
+66
| var path = "res://addons/" | ||
|
|
||
| var directory := Directory.new() | ||
| directory.make_dir(path) | ||
|
|
||
| if not directory.open(path) == OK: | ||
| print("Loader: failed to load ", path, ", return [] (open)") | ||
| return | ||
|
|
||
| if not directory.list_dir_begin(true, true) == OK: | ||
| print("Loader: failed to load ", path, ", return [] (list_dir_begin)") | ||
| return | ||
|
|
||
| while true: | ||
| var sub_path = directory.get_next() | ||
| print(sub_path) | ||
|
|
||
| if sub_path == "." or sub_path == ".." or sub_path.begins_with("_"): | ||
| continue | ||
|
|
||
| elif sub_path == "": | ||
| break |
Contributor
There was a problem hiding this comment.
This seems to be the exact same code as in _load_addons(path) further down in the file. Why is this duplicated?
Byteron
reviewed
Mar 30, 2021
Comment on lines
+363
to
+367
| if (side.controller == Side.Controller.AI): | ||
| var ai = Data.AIs[side.ai].new() | ||
| add_child(ai) | ||
| ai.initialize(side) | ||
| AIs[side] = ai |
Contributor
There was a problem hiding this comment.
These AI related changes should not be in the PR for mods.
Byteron
reviewed
Mar 30, 2021
| elif directory.current_is_dir(): | ||
| directory_data = _get_directory_data(directory.get_current_dir() + "/" + sub_path, directory_data, extentions, load_resource) | ||
| else: | ||
| sub_path = sub_path.replace(".import", "") |
Contributor
Author
There was a problem hiding this comment.
when exporting, the raw .pngs aren't kept, so this is a workaround.
Contributor
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.