feedTask not getting garbage collected#178
Open
patrickghannage wants to merge 1 commit into
Open
Conversation
hrdlotom
reviewed
Apr 3, 2023
| int hwmCompare = Long.compare(o1.highWaterMark, o2.highWaterMark); | ||
|
|
||
| if (hwmCompare == 0) { | ||
| return Integer.compare(o1.reqId.seqNum(), o2.reqId.seqNum()); |
Collaborator
There was a problem hiding this comment.
Let's say we have FeedContexts of equal HWM. The first feed context is still going to block the queue while waiting for a new transaction. At this point the FeedContext becomes inactive but is still blocking the queue that may be dangerously grow. This doesn't critically influence the functionality of Waltz as with new transaction old expired FeedContexts are all erased and active FeedContexts are served.
Partition.FeedTask.process:
if (highWaterMark < nextTransactionId) {
// Wait for more data or new feed context
feedSync.await(version);
}```
hrdlotom
approved these changes
Apr 3, 2023
Collaborator
hrdlotom
left a comment
hrdlotom
left a comment
There was a problem hiding this comment.
LGTM. Expired feed contexts will be poped out when new feed context is inserted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no append requests are happening on a certain partition, feed contexts may accumulate on the real time feed task queue of that partition server in case of a disconnection between a Waltz client and the server holding that partition.