Skip to content

Implement imaximumOf and iminimumOf#541

Open
ozkutuk wants to merge 1 commit intowell-typed:masterfrom
ozkutuk:ixminmax
Open

Implement imaximumOf and iminimumOf#541
ozkutuk wants to merge 1 commit intowell-typed:masterfrom
ozkutuk:ixminmax

Conversation

@ozkutuk
Copy link
Contributor

@ozkutuk ozkutuk commented Jan 30, 2026

Resolves #536.

@ozkutuk
Copy link
Contributor Author

ozkutuk commented Jan 30, 2026

I have simplified the newtypes and hence the Semigroup instances a bit and relied on Semigroup a => Monoid (Maybe a) instance from base instead. However, apparently that instance is only present since base == 4.11.0, so it breaks on GHC 8.2.2. I can revert back to the old implementation of embedding the Maybe within the newtypes, but maybe this is yet another reason to go forward with #532 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Idea: imaximumOf and iminimumOf

1 participant