Merged
Conversation
arybczak
force-pushed
the
ghc-9.14.1
branch
2 times, most recently
from
cf87cee to
1d00cdf
Compare
phadej
reviewed
Jan 26, 2026
optics/tests/Optics/Tests/Misc.hs
Outdated
| {-# OPTIONS_GHC -fplugin=Test.Inspection.Plugin -dsuppress-all #-} | ||
| #if __GLASGOW_HASKELL__ >= 914 | ||
| -- checkIxAdjoin case is too complicated for GHC-9.14 | ||
| -- TODO: remove this since it invalidates results of all tests in this module in a realistic scenario. |
Contributor
There was a problem hiding this comment.
create an issue if you are going to merge this PR with a TODO still in. Otherwise it will be simply forgotten.
Collaborator
Author
There was a problem hiding this comment.
Will do. I also created https://gitlab.haskell.org/ghc/ghc/-/issues/26831.
phadej
reviewed
Jan 26, 2026
cabal.project
Outdated
|
|
||
| tests: true | ||
|
|
||
| -- temporarily for GHC-9.14 |
Contributor
There was a problem hiding this comment.
ditto for this "temporary" thing. My bet, we'll touch cabal.project next only around GHC-9.16 is out.
Collaborator
Author
There was a problem hiding this comment.
Since you are a maintainer of both indexed-traversable and these, can you make appropriate revisions so it's not needed?
Contributor
There was a problem hiding this comment.
I cannot immediately, sorry, that will take some time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #531, also does some minor cleanup.