fix: correctly map selected layers to simulcast layers#134
Open
holzgeist wants to merge 2 commits intowebrtc-sdk:m125_releasefrom
Open
fix: correctly map selected layers to simulcast layers#134holzgeist wants to merge 2 commits intowebrtc-sdk:m125_releasefrom
holzgeist wants to merge 2 commits intowebrtc-sdk:m125_releasefrom
Conversation
this partly fixes webrtc-sdk#133. Quick summary: - on lower resolutions, simulcast only sends 2 (or even 1) layer. - The layers are ordered from low to high resolution (downscale factors 4, 2, 1) - previously, when only sending 2 layers (factors 2, 1), the layer with factor 2 was mapped to the layer with factor 4, i.e. scaled down again) - with this patch, the layers are mapped to the correct factor and not scaled down again
encoder_config.simulcast_layers.size() is always >= layers.size(), otherwise it not have worked before, so get rid of the (erronous) max
davidliu
requested changes
Jul 19, 2024
Contributor
davidliu
left a comment
davidliu
left a comment
There was a problem hiding this comment.
Don't think we can use this PR, as noted in the related issue:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this partly fixes #133.
Quick summary: