unify add/remove_track arguments for peer connections#523
Closed
w-utter wants to merge 1 commit intowebrtc-rs:masterfrom
Closed
unify add/remove_track arguments for peer connections#523w-utter wants to merge 1 commit intowebrtc-rs:masterfrom
w-utter wants to merge 1 commit intowebrtc-rs:masterfrom
Conversation
Member
|
why didn't this RP trigger github actions Checks? |
rainliu
force-pushed
the
master
branch
5 times, most recently
from
463d5f6 to
a1f8f19
Compare
rainliu
force-pushed
the
master
branch
2 times, most recently
from
81b0293 to
d28f7ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, RTCPeerConnection's remove_track took a
&Arc<RTCRtpSender>while its add_track took anArc<dyn TrackLocal + Send + Sync>for its argument, and semantically it makes sense for these two methods to have the same parameters.This would delegate checking whether the track exists on a given sender to the user before removing the track (as seen in the changes to the example), but I think its rare that a user would want to remove a track based on the sender rather than explicitly specifying the track.